Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WASM parser): parse correctly <Label> to a tag and not an attribute #1541

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix(WASM parser): parse correctly <Label> to a tag and not an attribute #1541

merged 2 commits into from
Sep 13, 2024

Conversation

Florent-Bouisset
Copy link
Collaborator

fixes [1540]

@peaBerberian
Copy link
Collaborator

Short and clean, LGTM.
Though prettier is not happy for some reasons.

@peaBerberian peaBerberian modified the milestone: 4.2.0 Sep 13, 2024
@peaBerberian peaBerberian added bug This is an RxPlayer issue (unexpected result when comparing to the API) DASH Relative to the DASH streaming protocol WASM Relative to our WebAssembly code Priority: 1 (High) This issue or PR has a high priority. labels Sep 13, 2024
@peaBerberian
Copy link
Collaborator

Waiting for the tests to merge it.

We can also backport it to the v3.

@Florent-Bouisset Florent-Bouisset mentioned this pull request Sep 13, 2024
Merged
@Florent-Bouisset
Copy link
Collaborator Author

Waiting for the tests to merge it.

We can also backport it to the v3.

I made it there #1543

@peaBerberian peaBerberian merged commit 2ca7291 into dev Sep 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This is an RxPlayer issue (unexpected result when comparing to the API) DASH Relative to the DASH streaming protocol Priority: 1 (High) This issue or PR has a high priority. WASM Relative to our WebAssembly code
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

[WASM Parser] Label is missed on all tracks
2 participants
@Florent-Bouisset @peaBerberian