fix: remove keyboard listerners and mark as unsupported #25

thiagobrez · 2023-10-27T18:49:37Z

Summary:

Fixes #6

Mark Keyboard.js and KeyboardAvoidingView.js as unsupported and remove listeners in RCTKeyboardObserver.mm, because VisionOS displays the keyboard in a separate window, leaving the app window unaffected.

Changelog:

[VISIONOS] [ADDED] - warning about unavailable Keyboard
[VISIONOS] [ADDED] - warning about unavailable KeyboardAvoidingView
[VISIONOS] [CHANGED] - early return when adding and removing listeners in Keyboard
[VISIONOS] [CHANGED] - return passthrough View when rendering KeyboardAvoidingView on VisionOS
[VISIONOS] [CHANGED] - do nothing if TARGET_OS_VISION in startObserving and stopObserving

Test Plan:

Open KeyboardAvoidingView in RNTester
Verify warn is displayed in the app and in the Metro logs
Verify examples should still load and function correctly

matthargett · 2023-10-28T21:54:11Z

packages/react-native/Libraries/Components/Keyboard/Keyboard.js

@@ -114,6 +114,13 @@ class Keyboard {
    );

  constructor() {
+    if (Platform.isVisionOS) {


Can we not create Keyboard.visionOS.js and have it return a noop or throw upon require? It seems like these if should be pulled into the Tester app itself, which is what I could expect in end-user app logic as well. If a visionOS app requires this file, and tries to use any methods, the developer probably isn't understanding the platform correctly.

It could be a possible solution but I think it's a nice DX to have instructions that this module is not supported on this platform.

We can wait with merging of this PR till we will implement the Platform.OS (for visionOS) and make it a noop file.

wouldn't the warning be annoying when writing cross platform apps?

Agree, if we have the .visionOS platform file, would also vote for removing warnings

There is also way to warnOnce as @satya164 said constant warning might be annoying. Looks like react-native-tvos is following this pattern:

okwasniewski · 2023-11-05T18:03:05Z

Hey! @thiagobrez

It would be great if you could rebase your PR and change calls to console.warn to warnOnce like in Tomek's PR here: #24

thiagobrez · 2023-11-05T18:21:02Z

Sorry for the delay @okwasniewski , I thought we were waiting on #20. Should be good now

okwasniewski · 2023-11-06T16:12:56Z

Thanks for this!

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

fix: address issues with scale, ScrollView prop feat: move min_visionos_version_supported to Helpers feat: implement `visionos_hoverStyle` prop chore: update README.MD fix: refactor visionos_hoverStyle to take a string and new arch support docs: add link to rn-tester's README.md (#5) chore: change VisionOS to visionOS (#13) chore: use `min_supported_versions` for third-party-podspecs (#18) chore: remove not necessary ifs TARGET_OS_VISION, minimise code diff (#22) feat: add visionos support add warning when using InputAccessoryView update platform naming fix: remove keyboard listerners and mark as unsupported (#25) * fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce feat: support building visionOS with dynamic frameworks enabled (#28) chore: sync Podfile.lock with upstream, remove unnecessary #endif feat: add visionOS as separate target to fix iOS tests (#31) * feat: add visionOS as separate target to fix iOS tests * fix: disable multiple windows support * feat: add visionOS App Icon * fix: creating Release build Update README.md (#36) * Update README.md * fix: update README link * feat: add caution section * fix: bring back info about Hermes Add platform guidelines to README (#37) * Add platform guidelines to README * fix: link to docs Rename react-native package to @callstack/react-native-visionos (#35) * rename react-native package to @callstack/react-native-visionos * fix typo * Make JS and TS tests independent of react-native package name * change name in template * replace more refs in e2e tests * revert tests changes * disable js e2e tests for visionos * bring back react-native for other platforms compat * ci: run js, no e2e js Fix codegen issues for RNTester after renaming package (#40) feat: make hermes build for visionOS (#26) * [WIP] feat: make hermes build for visionOS * feat: point to callstack/hermes-visionos fork, update README * fix: remove USE_HERMES from project.pbxproj feat: align unnecessary compiler conditionals (#51) chore: sync Podfile.lock feat: implement OOT release script (#43) * feat: implement OOT release script * docs: add readme on Release process * fix: remove header file Co-authored-by: Michał Pierzchała <[email protected]> * add reference --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add visionOS template (#34) * Update CLI to v12.1.1 * feat: implement visionos react-native template * feat: modify template look * feat: add `@callstack/out-of-tree-platforms` to metro config * fix: metro config * feat: update supported platforms --------- Co-authored-by: szymonrybczak <[email protected]> task(StatusBar component): show warn when using StatusBar (#49) * task(StatusBar component): show warn when using StatusBar * pr suggestions docs: update CMake instructions (#55) Fix iOS native tests (#58) * fix: remove unnecessary libevent.podspec * fix: make OCMock build for visionOS fix: remove unnecessary YogaKit pod (#61) feat: add warning while building Hermes that at least CMake 3.28.0 is required (#63) fix: RCTAlertController transparent background override added cornerRadius for hover style (#66) * added corner radius for hover style * fix: implement proper handling for old arch, reformat code --------- Co-authored-by: Oskar Kwaśniewski <[email protected]> chore: sync Podfile.lock fix: don't warn users about the Keyboard API (#71) feat: implement visionos cli commands (#64) fix: use isVision instead of isVisionOS (#76) fix: release build bundle (#74) fix: remove duplicated isVision key (#78) fix: change resolver option name (#79) fix: RCTDeviceInfo UIApplicationDidChangeStatusBarOrientationNotification method fix: update README.md with corrected capitalization (#84) fix: upstream sync ifdefs fix: providing unsupported value to hoverStyle crashed the app (#88) fix: pointer events (#114) fix: hoverEffect for bridgeless mode (#92) refactor: remove unused RCTForegroundWindow (#94) fix: properly retrieve window when clicking DevMenu action (#95) sync with upstream chore: sync Podfile.lock docs: add how is it different from iOS version section (#91) docs: move to documentation website (#119) Update README.md (#121) * Update README.md * Update README.md Co-authored-by: Kacper Rożniata <[email protected]> --------- Co-authored-by: Kacper Rożniata <[email protected]> Update getting started link in Readme. (#123) Co-authored-by: christinamartinez <[email protected]> chore: remove hover effect & add cursor: pointer (#122) * chore: remove hover effect * fix: set cursor pointer by default, update tests * feat(iOS): Implement cursor style prop --------- Co-authored-by: Saad Najmi <[email protected]> chore: resync with upstream fix: change versio of @callstack/out-of-tree-platforms feat: make SwiftUI React Native entry point (#68) * feat: add Swift entrypoint [wip] add module maps to some RN modules to allow for swift c++ imports feat: implement RCTReactController and RCTSwiftUIAppDelegate feat: introduce new method to RCTAppDelegate * feat: modify template to use SwiftUI * fix: dimensions, use RCTMainWindow() * fix: fallback to DarkMode on visionOS * fix: use KeyWindow() in RCTPerfMonitor feat: update docs (#80) * feat: update docs * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add UIApplicationSceneManifest to template Create custom resolver and utils package for out-of-tree platforms (#32) * rename react-native package to @callstack/react-native-visionos * wip: metro setup for other platform * fix(flow): add .ios.visionos as support platform * fix some flow errors * fix flow * revert Platform.select change * revert KeyboardAvoidingView change * fix type * change kBundlePath to ios.visionos * fix: remove redundant isVisionOS * use custom resolver options to read platform for OOT * fix types * remove formatting * add/remove platform checks * document variant behavior * use visionOS Keyboard mock * use visionOS KeyboardAvoidingView mock * use visionOS InputAccessoryView mock * test: add test for metroPlatformResolver * move implementation to user space * create out-of-tree-platforms package and bring back resolver options * revert flow changes * revert sourceExts changes * update links * add comments * fix visionos typo * adjust lockfile * revert loadMetroConfig change * remove podfile lock * revert scripts changes Fix build step for `@callstack/out-of-tree-platforms` (#46) * feat: setup @callstack/out-of-tree-platforms to build properly * feat: add build packages step to `oot-release.js` script * chore: format package.json fix(#48) local build of @callstack/out-of-tree-platforms (#50)

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

fix: address issues with scale, ScrollView prop feat: move min_visionos_version_supported to Helpers feat: implement `visionos_hoverStyle` prop chore: update README.MD fix: refactor visionos_hoverStyle to take a string and new arch support docs: add link to rn-tester's README.md (#5) chore: change VisionOS to visionOS (#13) chore: use `min_supported_versions` for third-party-podspecs (#18) chore: remove not necessary ifs TARGET_OS_VISION, minimise code diff (#22) feat: add visionos support add warning when using InputAccessoryView update platform naming fix: remove keyboard listerners and mark as unsupported (#25) * fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce feat: support building visionOS with dynamic frameworks enabled (#28) chore: sync Podfile.lock with upstream, remove unnecessary #endif feat: add visionOS as separate target to fix iOS tests (#31) * feat: add visionOS as separate target to fix iOS tests * fix: disable multiple windows support * feat: add visionOS App Icon * fix: creating Release build Update README.md (#36) * Update README.md * fix: update README link * feat: add caution section * fix: bring back info about Hermes Add platform guidelines to README (#37) * Add platform guidelines to README * fix: link to docs Rename react-native package to @callstack/react-native-visionos (#35) * rename react-native package to @callstack/react-native-visionos * fix typo * Make JS and TS tests independent of react-native package name * change name in template * replace more refs in e2e tests * revert tests changes * disable js e2e tests for visionos * bring back react-native for other platforms compat * ci: run js, no e2e js Fix codegen issues for RNTester after renaming package (#40) feat: make hermes build for visionOS (#26) * [WIP] feat: make hermes build for visionOS * feat: point to callstack/hermes-visionos fork, update README * fix: remove USE_HERMES from project.pbxproj feat: align unnecessary compiler conditionals (#51) chore: sync Podfile.lock feat: implement OOT release script (#43) * feat: implement OOT release script * docs: add readme on Release process * fix: remove header file Co-authored-by: Michał Pierzchała <[email protected]> * add reference --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add visionOS template (#34) * Update CLI to v12.1.1 * feat: implement visionos react-native template * feat: modify template look * feat: add `@callstack/out-of-tree-platforms` to metro config * fix: metro config * feat: update supported platforms --------- Co-authored-by: szymonrybczak <[email protected]> task(StatusBar component): show warn when using StatusBar (#49) * task(StatusBar component): show warn when using StatusBar * pr suggestions docs: update CMake instructions (#55) Fix iOS native tests (#58) * fix: remove unnecessary libevent.podspec * fix: make OCMock build for visionOS fix: remove unnecessary YogaKit pod (#61) feat: add warning while building Hermes that at least CMake 3.28.0 is required (#63) fix: RCTAlertController transparent background override added cornerRadius for hover style (#66) * added corner radius for hover style * fix: implement proper handling for old arch, reformat code --------- Co-authored-by: Oskar Kwaśniewski <[email protected]> chore: sync Podfile.lock fix: don't warn users about the Keyboard API (#71) feat: implement visionos cli commands (#64) fix: use isVision instead of isVisionOS (#76) fix: release build bundle (#74) fix: remove duplicated isVision key (#78) fix: change resolver option name (#79) fix: RCTDeviceInfo UIApplicationDidChangeStatusBarOrientationNotification method fix: update README.md with corrected capitalization (#84) fix: upstream sync ifdefs fix: providing unsupported value to hoverStyle crashed the app (#88) fix: pointer events (#114) fix: hoverEffect for bridgeless mode (#92) refactor: remove unused RCTForegroundWindow (#94) fix: properly retrieve window when clicking DevMenu action (#95) sync with upstream chore: sync Podfile.lock docs: add how is it different from iOS version section (#91) docs: move to documentation website (#119) Update README.md (#121) * Update README.md * Update README.md Co-authored-by: Kacper Rożniata <[email protected]> --------- Co-authored-by: Kacper Rożniata <[email protected]> Update getting started link in Readme. (#123) Co-authored-by: christinamartinez <[email protected]> chore: remove hover effect & add cursor: pointer (#122) * chore: remove hover effect * fix: set cursor pointer by default, update tests * feat(iOS): Implement cursor style prop --------- Co-authored-by: Saad Najmi <[email protected]> chore: resync with upstream fix: change versio of @callstack/out-of-tree-platforms feat: make SwiftUI React Native entry point (#68) * feat: add Swift entrypoint [wip] add module maps to some RN modules to allow for swift c++ imports feat: implement RCTReactController and RCTSwiftUIAppDelegate feat: introduce new method to RCTAppDelegate * feat: modify template to use SwiftUI * fix: dimensions, use RCTMainWindow() * fix: fallback to DarkMode on visionOS * fix: use KeyWindow() in RCTPerfMonitor feat: update docs (#80) * feat: update docs * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add UIApplicationSceneManifest to template Create custom resolver and utils package for out-of-tree platforms (#32) * rename react-native package to @callstack/react-native-visionos * wip: metro setup for other platform * fix(flow): add .ios.visionos as support platform * fix some flow errors * fix flow * revert Platform.select change * revert KeyboardAvoidingView change * fix type * change kBundlePath to ios.visionos * fix: remove redundant isVisionOS * use custom resolver options to read platform for OOT * fix types * remove formatting * add/remove platform checks * document variant behavior * use visionOS Keyboard mock * use visionOS KeyboardAvoidingView mock * use visionOS InputAccessoryView mock * test: add test for metroPlatformResolver * move implementation to user space * create out-of-tree-platforms package and bring back resolver options * revert flow changes * revert sourceExts changes * update links * add comments * fix visionos typo * adjust lockfile * revert loadMetroConfig change * remove podfile lock * revert scripts changes Fix build step for `@callstack/out-of-tree-platforms` (#46) * feat: setup @callstack/out-of-tree-platforms to build properly * feat: add build packages step to `oot-release.js` script * chore: format package.json fix(#48) local build of @callstack/out-of-tree-platforms (#50)

fix: address issues with scale, ScrollView prop feat: move min_visionos_version_supported to Helpers feat: implement `visionos_hoverStyle` prop chore: update README.MD fix: refactor visionos_hoverStyle to take a string and new arch support docs: add link to rn-tester's README.md (#5) chore: change VisionOS to visionOS (#13) chore: use `min_supported_versions` for third-party-podspecs (#18) chore: remove not necessary ifs TARGET_OS_VISION, minimise code diff (#22) feat: add visionos support add warning when using InputAccessoryView update platform naming fix: remove keyboard listerners and mark as unsupported (#25) * fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce feat: support building visionOS with dynamic frameworks enabled (#28) chore: sync Podfile.lock with upstream, remove unnecessary #endif feat: add visionOS as separate target to fix iOS tests (#31) * feat: add visionOS as separate target to fix iOS tests * fix: disable multiple windows support * feat: add visionOS App Icon * fix: creating Release build Update README.md (#36) * Update README.md * fix: update README link * feat: add caution section * fix: bring back info about Hermes Add platform guidelines to README (#37) * Add platform guidelines to README * fix: link to docs Rename react-native package to @callstack/react-native-visionos (#35) * rename react-native package to @callstack/react-native-visionos * fix typo * Make JS and TS tests independent of react-native package name * change name in template * replace more refs in e2e tests * revert tests changes * disable js e2e tests for visionos * bring back react-native for other platforms compat * ci: run js, no e2e js Fix codegen issues for RNTester after renaming package (#40) feat: make hermes build for visionOS (#26) * [WIP] feat: make hermes build for visionOS * feat: point to callstack/hermes-visionos fork, update README * fix: remove USE_HERMES from project.pbxproj feat: align unnecessary compiler conditionals (#51) chore: sync Podfile.lock feat: implement OOT release script (#43) * feat: implement OOT release script * docs: add readme on Release process * fix: remove header file Co-authored-by: Michał Pierzchała <[email protected]> * add reference --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add visionOS template (#34) * Update CLI to v12.1.1 * feat: implement visionos react-native template * feat: modify template look * feat: add `@callstack/out-of-tree-platforms` to metro config * fix: metro config * feat: update supported platforms --------- Co-authored-by: szymonrybczak <[email protected]> task(StatusBar component): show warn when using StatusBar (#49) * task(StatusBar component): show warn when using StatusBar * pr suggestions docs: update CMake instructions (#55) Fix iOS native tests (#58) * fix: remove unnecessary libevent.podspec * fix: make OCMock build for visionOS fix: remove unnecessary YogaKit pod (#61) feat: add warning while building Hermes that at least CMake 3.28.0 is required (#63) fix: RCTAlertController transparent background override added cornerRadius for hover style (#66) * added corner radius for hover style * fix: implement proper handling for old arch, reformat code --------- Co-authored-by: Oskar Kwaśniewski <[email protected]> chore: sync Podfile.lock fix: don't warn users about the Keyboard API (#71) feat: implement visionos cli commands (#64) fix: use isVision instead of isVisionOS (#76) fix: release build bundle (#74) fix: remove duplicated isVision key (#78) fix: change resolver option name (#79) fix: RCTDeviceInfo UIApplicationDidChangeStatusBarOrientationNotification method fix: update README.md with corrected capitalization (#84) fix: upstream sync ifdefs fix: providing unsupported value to hoverStyle crashed the app (#88) fix: pointer events (#114) fix: hoverEffect for bridgeless mode (#92) refactor: remove unused RCTForegroundWindow (#94) fix: properly retrieve window when clicking DevMenu action (#95) sync with upstream chore: sync Podfile.lock docs: add how is it different from iOS version section (#91) docs: move to documentation website (#119) Update README.md (#121) * Update README.md * Update README.md Co-authored-by: Kacper Rożniata <[email protected]> --------- Co-authored-by: Kacper Rożniata <[email protected]> Update getting started link in Readme. (#123) Co-authored-by: christinamartinez <[email protected]> chore: remove hover effect & add cursor: pointer (#122) * chore: remove hover effect * fix: set cursor pointer by default, update tests * feat(iOS): Implement cursor style prop --------- Co-authored-by: Saad Najmi <[email protected]> chore: resync with upstream fix: change versio of @callstack/out-of-tree-platforms feat: make SwiftUI React Native entry point (#68) * feat: add Swift entrypoint [wip] add module maps to some RN modules to allow for swift c++ imports feat: implement RCTReactController and RCTSwiftUIAppDelegate feat: introduce new method to RCTAppDelegate * feat: modify template to use SwiftUI * fix: dimensions, use RCTMainWindow() * fix: fallback to DarkMode on visionOS * fix: use KeyWindow() in RCTPerfMonitor feat: update docs (#80) * feat: update docs * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> * Update README.md Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]> feat: add UIApplicationSceneManifest to template Create custom resolver and utils package for out-of-tree platforms (#32) * rename react-native package to @callstack/react-native-visionos * wip: metro setup for other platform * fix(flow): add .ios.visionos as support platform * fix some flow errors * fix flow * revert Platform.select change * revert KeyboardAvoidingView change * fix type * change kBundlePath to ios.visionos * fix: remove redundant isVisionOS * use custom resolver options to read platform for OOT * fix types * remove formatting * add/remove platform checks * document variant behavior * use visionOS Keyboard mock * use visionOS KeyboardAvoidingView mock * use visionOS InputAccessoryView mock * test: add test for metroPlatformResolver * move implementation to user space * create out-of-tree-platforms package and bring back resolver options * revert flow changes * revert sourceExts changes * update links * add comments * fix visionos typo * adjust lockfile * revert loadMetroConfig change * remove podfile lock * revert scripts changes Fix build step for `@callstack/out-of-tree-platforms` (#46) * feat: setup @callstack/out-of-tree-platforms to build properly * feat: add build packages step to `oot-release.js` script * chore: format package.json fix(#48) local build of @callstack/out-of-tree-platforms (#50) feat: Automate releases to GitHub (#83) fix: adjust oot-release script for stable releases (#85) fix: hermes xcode build scripts (#133) feat: release scripts chore: sync with upstream chore: sync with upstream chore: sync with upstream prevent keyboard api in ScrollView (#143) chore: sync with upstream feat: include privacy info manifest (#144) chore: sync with upstream fix: local commands parameters (#134) fix: add missing index.flow.js file to out-of-tree-platforms package

thiagobrez mentioned this pull request Oct 27, 2023

Mark Keyboard module as unsupported on VisionOS #6

Closed

matthargett reviewed Oct 28, 2023

View reviewed changes

okwasniewski force-pushed the main branch 2 times, most recently from 20e86cb to d51d6a7 Compare November 3, 2023 10:11

thiagobrez added 2 commits November 5, 2023 18:11

fix: remove keyboard listerners and mark as unsupported

1759b93

chore: replace warn with warnOnce

3341d27

okwasniewski merged commit 471f9be into callstack:main Nov 6, 2023
1 of 2 checks passed

okwasniewski pushed a commit that referenced this pull request Nov 8, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

d7cadf1

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 8, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

d9d83f7

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 9, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

a412e15

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 16, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

9a4327f

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 23, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

8c25f4d

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 28, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

68e52e2

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Nov 29, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

12aa138

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Dec 5, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

fa59257

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Dec 11, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

f8da6c3

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Dec 12, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

b9615ee

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Dec 14, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

bb74861

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Dec 20, 2023

fix: remove keyboard listerners and mark as unsupported (#25)

560caf9

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 2, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

f9830af

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 8, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

a68efc4

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 11, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

7d06911

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 19, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

36834db

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 23, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

92b67f7

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 26, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

010256e

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jan 31, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

7e51d7f

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Feb 2, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

a7823d2

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

okwasniewski pushed a commit that referenced this pull request Jun 24, 2024

fix: remove keyboard listerners and mark as unsupported (#25)

8b38ba3

* fix: remove keyboard listerners and mark as unsupported * chore: replace warn with warnOnce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove keyboard listerners and mark as unsupported #25

fix: remove keyboard listerners and mark as unsupported #25

thiagobrez commented Oct 27, 2023 •

edited

Loading

matthargett Oct 28, 2023

okwasniewski Oct 29, 2023 •

edited

Loading

satya164 Oct 29, 2023

thiagobrez Oct 30, 2023

okwasniewski Oct 30, 2023

okwasniewski commented Nov 5, 2023

thiagobrez commented Nov 5, 2023

okwasniewski commented Nov 6, 2023

fix: remove keyboard listerners and mark as unsupported #25

fix: remove keyboard listerners and mark as unsupported #25

Conversation

thiagobrez commented Oct 27, 2023 • edited Loading

Summary:

Changelog:

Test Plan:

matthargett Oct 28, 2023

Choose a reason for hiding this comment

okwasniewski Oct 29, 2023 • edited Loading

Choose a reason for hiding this comment

satya164 Oct 29, 2023

Choose a reason for hiding this comment

thiagobrez Oct 30, 2023

Choose a reason for hiding this comment

okwasniewski Oct 30, 2023

Choose a reason for hiding this comment

okwasniewski commented Nov 5, 2023

thiagobrez commented Nov 5, 2023

okwasniewski commented Nov 6, 2023

thiagobrez commented Oct 27, 2023 •

edited

Loading

okwasniewski Oct 29, 2023 •

edited

Loading