Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feat/more flexible text input #316

Closed
wants to merge 3 commits into from

Conversation

nyablo
Copy link
Contributor

@nyablo nyablo commented Apr 16, 2018

Motivation

What existing problem does the pull request solve?

It was impossible to change style(padding in my case) of the NativeTextInput.

Can you solve the issue with a different approach?

No.

Test plan

List the steps with which we can test this change. Provide screenshots if this changes anything visual.
just pass textInputStyle={{paddingTop: 0}} to the TextInput component.

@callstack-bot
Copy link

callstack-bot commented Apr 16, 2018

Hey @NazarYablonskiy, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@satya164
Copy link
Member

I'd prefer not to add props to customize internals of a component since it prevents us from changing them later as it'll break people's code. Can you post a screenshot of what you want to achieve and we can figure out a way to do that?

@nyablo
Copy link
Contributor Author

nyablo commented Apr 16, 2018

@satya164 I'd like to reduce paddingTop. Also, I'd like to manually control style of the underline (the second text input)

screen shot 2018-04-16 at 14 00 40

@satya164
Copy link
Member

I'd like to reduce paddingTop

So basically you don't want a huge top padding when there is no label, right? Looks like a bug on our end. We can change it in the component directly.

Also, I'd like to manually control style of the underline (the second text input)

Regarding error state, we're working on it. We'll have a proper underline with the line height according to MD guidelines (#243).

@nyablo
Copy link
Contributor Author

nyablo commented Apr 16, 2018

@satya164 awesome! eta?

@nyablo nyablo closed this Apr 16, 2018
@satya164
Copy link
Member

No ETA, but we'll try to get it merged ASAP. Meanwhile, you could use https://github.com/ds300/patch-package to apply your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants