Fixing 'remote image' button example #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrannp
approved these changes
Jan 31, 2018
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
* fix: Updating uri link in ButtonExample (the current one gives 404 and no image displayed). * fix: Updating uri link in ButtonExample (svg doesn't work well).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old URI points to a 404 right now, as the React's logo on Facebook's page is now a data URI. Ideally, we could host the used image on callstack.github.io, but the current push process prevents us from that.