fix: don't create example app for local library

callstack · Dec 9, 2024 · 4f64b22 · 4f64b22
1 parent b8c3293
commit 4f64b22
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/packages/create-react-native-library/src/inform.ts b/packages/create-react-native-library/src/inform.ts
@@ -54,7 +54,7 @@ export async function printNextSteps(
             )} to link the library\n`
           : `- Link the library at ${kleur.blue(
               path.relative(process.cwd(), folder)
-            )} based on your project setup'\n`) +
+            )} based on your project setup\n`) +
         `- Run ${kleur.blue(
           'pod install --project-directory=ios'
         )} to install dependencies with CocoaPods\n` +

diff --git a/packages/create-react-native-library/src/input.ts b/packages/create-react-native-library/src/input.ts
@@ -282,14 +282,20 @@ export async function createQuestions({
         });
       },
     },
-  ];
-
-  if (!local) {
-    questions.push({
+    {
       type: 'select',
       name: 'example',
       message: 'What type of example app do you want to create?',
       choices: (_, values) => {
+        if (local) {
+          return [
+            {
+              title: 'None',
+              value: 'none',
+            },
+          ];
+        }
+
         return EXAMPLE_CHOICES.filter((choice) => {
           if (values.type) {
             return values.type === 'library'
@@ -300,8 +306,8 @@ export async function createQuestions({
           return true;
         });
       },
-    });
-  }
+    },
+  ];
 
   return questions;
 }

diff --git a/packages/create-react-native-library/src/utils/prompt.ts b/packages/create-react-native-library/src/utils/prompt.ts
@@ -42,8 +42,14 @@ export async function prompt<T extends string>(
         continue;
       }
 
+      const { type, choices } = question;
+
       // Don't prompt questions with a single choice
-      if (Array.isArray(question.choices) && question.choices.length === 1) {
+      if (
+        type === 'select' &&
+        Array.isArray(question.choices) &&
+        question.choices.length === 1
+      ) {
         const onlyChoice = question.choices[0];
 
         if (onlyChoice?.value) {
@@ -54,8 +60,6 @@ export async function prompt<T extends string>(
         continue;
       }
 
-      const { type, choices } = question;
-
       // Don't prompt dynamic questions with a single choice
       if (type === 'select' && typeof choices === 'function') {
         question.type = (prev, values) => {