Fix exceptions when app is running with different locale than english #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @rajdeepv - we've just fixed an issue with our CI build but unfortunately this means that this PR has failed some checks. Please could you rebase your changes against develop and resend the PR? I don't think we have any issues with this change so hopefully we can get this merged in soon. |
|
@owenniblock Done, Thanks! |
This was referenced Dec 12, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS: Android Nogut (7.1)
Locale: Turkish 'tr'
QUERY:
query("* id:'content' child android.widget.FrameLayout")
ERROR:
query failed because: No enum constant sh.calaba.instrumentationbackend.query.ast.UIQueryDirection.CHİLD
(RuntimeError)
REASON
sh/calaba/instrumentationbackend/query/Query.java:162
step.getText().toUpperCase() yields "CHİLD" instead of "CHILD" (notice a dot above 'I' here because locale of app is not english)
Similarly, query("* {text like '* hello *'}") changes predicate to LİKE instead of LIKE