Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace metalinter with golangci-lint #999

Merged
merged 2 commits into from
May 20, 2019
Merged

Replace metalinter with golangci-lint #999

merged 2 commits into from
May 20, 2019

Conversation

zhujian7
Copy link
Collaborator

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #974

Reference to #

Special notes for your reviewer:

/cc @supereagle @cd1989

Release note:

NONE

@caicloud-bot caicloud-bot requested review from cd1989 and supereagle May 17, 2019 07:12
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2019
@zhujian7 zhujian7 force-pushed the golangci-lint branch 2 times, most recently from fea9439 to 61746ec Compare May 17, 2019 08:04
@zhujian7
Copy link
Collaborator Author

/hold

@caicloud-bot caicloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2019
@supereagle
Copy link
Member

@zhujian7 Good work👍

@zhujian7
Copy link
Collaborator Author

/hold cancel

@caicloud-bot caicloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2019
supereagle
supereagle approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@supereagle supereagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2019
@supereagle
Copy link
Member

/approve

@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Collaborator Author

/hold

@caicloud-bot caicloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2019
@zhujian7
Copy link
Collaborator Author

/hold cancel

@caicloud-bot caicloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2019
@caicloud-bot caicloud-bot merged commit 803fbf8 into caicloud:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supereagle supereagle supereagle approved these changes

@cd1989 cd1989 Awaiting requested review from cd1989

Assignees

@supereagle supereagle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from gometalinter to golangci-lint
3 participants
@zhujian7 @supereagle @caicloud-bot