Complete tasks on stanbdy cluster for workflows that don't exist anymore #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
sankari165 and
dkrotx
as code owners
davidporter-id-au
approved these changes
Dec 10, 2024
…sks with workflow not found
fimanishi
requested review from
jakobht,
3vilhamster,
taylanisikdemir and
demirkayaender
as code owners
| errTaskNotStarted = errors.New("task not started") | ||
| errDomainIsActive = &DomainIsActiveInThisClusterError{Message: "domain is active"} | ||
| historyServiceOperationRetryPolicy = common.CreateTaskCompleterRetryPolicy() | ||
| errWorkflowExecutionInfoIsNil = errors.New("workflow execution info is nil") |
There was a problem hiding this comment.
urgh, not for this PR, but we probably want to move away from this pattern:
- the unexported errors we can't check against
- I think, generally, exporting a type error is preferable than a static var error (ie
type ErrDomainNotActive struct {
Message string
}
There was a problem hiding this comment.
Will refactor in a later PR
davidporter-id-au
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow for completion of tasks on standby cluster if the workflow doesn't exist anymore
Why?
If the retention period after workflow completion has passed, the workflow will be deleted from the database. If tasks from these workflows were not already completed (because they were already there before the implementation of the feature) they will block completion of future tasks.
How did you test it?
Tested locally and will validate again in a staging environment.
Potential risks
Before tasks are pushed to the matching, it's checked to see if the workflow execution is present. Because we are checking for a specific error here, I don't think there is risk added.
Release notes
Documentation Changes