Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Introduce new invariant to identify activity and workflow failures #6339

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

sankari165
Copy link
Member

What changed?
New invariant check to identify non timeout failures

Why?
The primary cause of workflow failures are from activity failures. While timeouts can cause an activity to fail, there are also a bunch of errors that we return for activity failures.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.73%. Comparing base (a155019) to head (bb14eb5).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ce/worker/diagnostics/invariant/failure/failure.go 92.30% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ce/worker/diagnostics/invariant/timeout/timeout.go 86.88% <100.00%> (ø)
...ker/diagnostics/invariant/timeout/timeout_utils.go 82.43% <ø> (-0.69%) ⬇️
...ce/worker/diagnostics/invariant/failure/failure.go 92.30% <92.30%> (ø)

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a155019...bb14eb5. Read the comment docs.

@sankari165 sankari165 enabled auto-merge (squash) October 9, 2024 11:17
@sankari165 sankari165 merged commit 74ec9b1 into cadence-workflow:master Oct 9, 2024
16 of 18 checks passed
@sankari165 sankari165 deleted the CDNC-10786-invariant branch October 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants