Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] start/signalstart workflow requests should include headers from opentracing SpanContext #6329

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

shijiesheng
Copy link
Member

What changed?

  • extract headers from span context in CLI commands and populate the header field in the request body

Why?

Context propagation is done through headers field

How did you test it?

Unit test to ensure the baggage item is propagated

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (b92f122) to head (c825231).

Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/workflow_commands.go 37.81% <100.00%> (+0.38%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92f122...c825231. Read the comment docs.

@shijiesheng shijiesheng merged commit bac706c into cadence-workflow:master Oct 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants