Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] replace BackgroundContext with CLI's context #6328

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

shijiesheng
Copy link
Member

What changed?
Instead of using background context. Use CLI's provided context.

Why?

New CLI framework allows passing a root context from app.RunContext. We want to follow this practice to simplify things like jwt / opentracing propagation.

How did you test it?

unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.61%. Comparing base (d4884cc) to head (825f23b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tools/cli/admin_elastic_search_commands.go 0.00% 4 Missing ⚠️
tools/cli/admin_db_scan_command.go 0.00% 1 Missing ⚠️
tools/cli/admin_kafka_commands.go 0.00% 1 Missing ⚠️
tools/cli/admin_timers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/utils.go 55.98% <100.00%> (ø)
tools/cli/workflow_commands.go 37.43% <100.00%> (ø)
tools/cli/admin_db_scan_command.go 0.00% <0.00%> (ø)
tools/cli/admin_kafka_commands.go 0.00% <0.00%> (ø)
tools/cli/admin_timers.go 0.00% <0.00%> (ø)
tools/cli/admin_elastic_search_commands.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4884cc...825f23b. Read the comment docs.

@shijiesheng shijiesheng merged commit b92f122 into cadence-workflow:master Oct 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants