move permember ratelimiter to it's own package #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
This is required to break the the cyclic dependency and allow membership' tests to use testlogger package
dkrotx
force-pushed
the
break-observer-and-membership-cycle
branch
from
c294127 to
eac4235
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Sep 26, 2024
dkrotx
added a commit
to dkrotx/cadence
that referenced
this pull request
Sep 26, 2024
This is required to break the the cyclic dependency and allow membership' tests to use testlogger package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This is required to break the the cyclic dependency and allow
membership' tests to use testlogger package
Why?
Otherwise can't use testlogger within membership tests
How did you test it?
unit-tests
Potential risks
Release notes
Documentation Changes