-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow info details in QueryToken #6265
Add workflow info details in QueryToken #6265
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -1722,8 +1722,8 @@ func (wh *WorkflowHandler) RespondQueryTaskCompleted( | |||
sizeLimitError, | |||
queryTaskToken.DomainID, | |||
domainName, | |||
"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this looked weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll merge it without unit tests. We will have to introduce an integration test in matching that will cover QueryTasks. |
What changed?
I've added workflow context fields to QueryToken so it can be accessed during request/response processing.
Why?
We want to be able to identify concrete workflow executions when RespondQueryTaskCompleted fails. To achieve this, we need to propagate workflow information.
The easiest way is to put this information into QueryToken. The fields are optional and, in the worst case, will be empty as they are now.
How did you test it?
Unit tests.
However, the matching service is missing tests related to Query processing. I'll try adding tests in this PR or creating a separate PR to address this.
Potential risks
Release notes
Documentation Changes