Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update task executor to handle WorkflowAlreadyCompletedError for signal and cancel workflow (#5956)" #6026

Merged
merged 1 commit into from
May 17, 2024

Conversation

Shaddoll
Copy link
Member

This reverts commit d877674.

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f846a-0ed9-49e5-ba3b-9becb261ef60

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.06%) to 69.2%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 78.28%
service/history/task/transfer_standby_task_executor.go 2 87.65%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/historyManager.go 2 66.67%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018f7d41-214c-49c8-a08a-b3943f592412: 0.06%
Covered Lines: 101867
Relevant Lines: 147206

💛 - Coveralls

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.99%. Comparing base (f1a4bad) to head (b50e3b0).

Additional details and impacted files
Files Coverage Δ
...history/task/cross_cluster_source_task_executor.go 68.15% <ø> (-0.80%) ⬇️
...vice/history/task/transfer_active_task_executor.go 68.66% <100.00%> (-0.14%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a4bad...b50e3b0. Read the comment docs.

@Shaddoll Shaddoll merged commit 02c7efb into cadence-workflow:master May 17, 2024
20 checks passed
@Shaddoll Shaddoll deleted the enum branch May 17, 2024 03:12
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants