Replication task processor shutdown improvements and start/stop unit tests #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018f5bab-298d-44df-b8e1-67f02e0ff1dfDetails
💛 - Coveralls |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
force-pushed
the
taylan/history_leak_test
branch
from
f15b6f0 to
577782d
Compare
timl3136
approved these changes
May 9, 2024
taylanisikdemir
commented
May 9, 2024
Comment on lines
+200
to
+207
| case p.requestChan <- &request{ | ||
| token: &types.ReplicationToken{ | ||
| ShardID: int32(p.shard.GetShardID()), | ||
| LastRetrievedMessageID: p.lastRetrievedMessageID, | ||
| LastProcessedMessageID: p.lastProcessedMessageID, | ||
| }, | ||
| respChan: respChan, | ||
| }: |
There was a problem hiding this comment.
previously this was done inside sendFetchMessageRequest which was not checking p.done and blocking shutdowns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replication task processor was not waiting for underlying goroutines when stopped. Added a waitgroup to fix that and validated with a unit test using
goleak.VerifyNoneAlso added similar leak check in history engine's start/stop test.
Why?
Improve shutdowns and code coverage
How did you test it?
unit test