Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor common/persistence/pinot tests #5777

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

bowenxia
Copy link
Member

What changed?
Refactored test code in common/persistence/pinot

Why?
follow the best practice

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@bowenxia bowenxia enabled auto-merge (squash) March 11, 2024 23:07

if test.expectedError != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea moving the setup to table items to make it more declarative

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #5777 (60c4ef5) into master (646ac32) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 60c4ef5 differs from pull request most recent head 34a163e. Consider uploading reports for the commit 34a163e to get more accurate results

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 646ac32...34a163e. Read the comment docs.

@bowenxia bowenxia merged commit 7ef6c99 into master Mar 11, 2024
19 checks passed
@bowenxia bowenxia deleted the xbowen_pinotVisibilityMetricClientTest_refactor branch March 11, 2024 23:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e2fc5-923b-4ae3-9939-51f10add70e1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 40 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.01%) to 64.081%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/matcher.go 2 90.72%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/task/fetcher.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
Totals Coverage Status
Change from base Build 018e2f4b-d603-4ac3-a9fe-ca4a4782f5fe: 0.01%
Covered Lines: 93424
Relevant Lines: 145791

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants