Set proper max reset points #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018d41f2-3423-449d-9af5-db68f9f3ea68
💛 - Coveralls |
service/history/execution/mutable_state_decision_task_manager.go
Outdated
Show resolved
Hide resolved
taylanisikdemir
approved these changes
Jan 24, 2024
davidporter-id-au
approved these changes
Jan 24, 2024
neil-xie
force-pushed
the
neilx_fix_binary_checksums
branch
from
b31ab64 to
61e251c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update to get max reset points from the config instead of math.MaxInt32
Why?
The number of binary checksums are growing unlimitedly, which will hammer the persistence
It also exceeds the limit of pinot json index length eventually
How did you test it?
Potential risks
Release notes
Documentation Changes