Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a unit test for the timer.go file in reconciliation folder. #5505

Merged
merged 16 commits into from
Dec 22, 2023

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Dec 19, 2023

What changed?
Added a unit test for the timer.go file in reconciliation folder.

Test Cases:

  • success
  • Invalid Timer Causes Error
  • Non-nil Pagination Token Passed

Why?
To improve the unit test coverage.

How did you test it?
tested locally

Potential risks
NA

Release notes
NA

Documentation Changes
NA

dkrotx
dkrotx previously requested changes Dec 20, 2023
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Outdated Show resolved Hide resolved
common/reconciliation/fetcher/timer_test.go Show resolved Hide resolved
@agautam478 agautam478 requested a review from dkrotx December 20, 2023 22:33
@agautam478 agautam478 merged commit 498b546 into cadence-workflow:master Dec 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants