fix leaky goroutines in matching #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
fix-leaky-goroutines-in-matching
branch
from
3741401 to
b9cb50c
Compare
dkrotx
reviewed
Dec 19, 2023
| @@ -31,6 +31,7 @@ import ( | |||
| "github.com/pborman/uuid" | |||
| "github.com/stretchr/testify/assert" | |||
| "github.com/stretchr/testify/require" | |||
|
|
|||
There was a problem hiding this comment.
this is most probably because of Go 1.21 != CI (1.20)
There was a problem hiding this comment.
Lets address this after @Groxx PR. Then everything will be unified.
Comment on lines
+157
to
+158
| tr.stopWg.Add(1) | ||
| defer tr.stopWg.Done() |
There was a problem hiding this comment.
Looks like a generic approach for stopping. I wonder if it's possible to have some OOP around this.
There was a problem hiding this comment.
OOP in Go is hard, I'm not aware of generic solutions on this.
dkrotx
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed matching taskReader stop not waiting for stopping underlying dispatchers.
Why?
With recent logging changes this leaks produces:
How did you test it?
Run integration tests
Potential risks
Release notes
Documentation Changes