Add unit tests for cassandra workflow utils part-1 #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
commented
Dec 13, 2023
| "github.com/google/go-cmp/cmp" | ||
| "github.com/pborman/uuid" | ||
| ) | ||
|
|
There was a problem hiding this comment.
This file has the new unit tests. Rest of the diff is about refactoring mentioned in the PR description.
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
taylanisikdemir
force-pushed
the
taylan/workflow_utils_tests_part_1
branch
from
4664711 to
f6178f9
Compare
taylanisikdemir
force-pushed
the
taylan/workflow_utils_tests_part_1
branch
from
f6178f9 to
31e6bdd
Compare
Shaddoll
reviewed
Dec 14, 2023
Shaddoll
reviewed
Dec 14, 2023
Shaddoll
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
workflowUtils.go encapsulates helper functions to generate cassandra queries against execution table. It had 0% code coverage so decided to write some unit tests for it. The file has 1.3k lines so there will be follow up PR to cover the rest. New tests are written following table driven approach without any test suite or mock library (used fakes instead).
Also did some refactoring in the same
common/persistence/nosql/nosqlplugin/cassandrafolder:cdbstruct because they don't use anything from struct.*_cql.gofilesWhy?
Improve code coverage and quality.
How did you test it?
make test