Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow started metric #5443

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix workflow started metric #5443

merged 2 commits into from
Nov 10, 2023

Conversation

ketsiambaku
Copy link
Contributor

What changed?
Changed metric tag from domainID to domainName

Why?
Currently the metric is tagged with domainID and is being disregarded by M3 due to cardinality

How did you test it?
Deployed the change in dev environment

Potential risks
Metric break/inaccuracy

Release notes

Documentation Changes

Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ketsiambaku ketsiambaku merged commit b6d6592 into master Nov 10, 2023
16 checks passed
@ketsiambaku ketsiambaku deleted the fix-metric-wfstart branch November 10, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants