Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log user query param #5437

Merged
merged 121 commits into from
Nov 15, 2023
Merged

Add log user query param #5437

merged 121 commits into from
Nov 15, 2023

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Nov 1, 2023

What changed?
Add log user query param

Why?
for Pinot/ES comparator usage

How did you test it?
unit test, integration test

Potential risks

Release notes

Documentation Changes

neil-xie and others added 30 commits September 28, 2023 12:51
common/service/config.go Outdated Show resolved Hide resolved
@neil-xie
Copy link
Member

neil-xie commented Nov 8, 2023

Is there any reason we parse the query here instead of doing it in the workflow? I am asking because if we moved to the workflow code, it will be much easier here to log and export the queries, we don't need to remove the code after migration, etc.

@bowenxia
Copy link
Member Author

bowenxia commented Nov 8, 2023

Is there any reason we parse the query here instead of doing it in the workflow? I am asking because if we moved to the workflow code, it will be much easier here to log and export the queries, we don't need to remove the code after migration, etc.

You are right. We can put it in the workflow.

Copy link
Member

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowenxia bowenxia merged commit bf90439 into master Nov 15, 2023
16 checks passed
@bowenxia bowenxia deleted the CDNC_6066_log_user_query_param branch November 15, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants