fix: temporary HTTP2 fix until <nodejs/node#30894> and <#133> are fur…

…ther investigated
cabinjs · Dec 11, 2019 · 24afa7a · 24afa7a
1 parent 05da578
commit 24afa7a
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/src/middleware.js b/src/middleware.js
@@ -47,7 +47,19 @@ module.exports = function(...args) {
               // and so we need `parse-request` to parse the `responseHeaders`
               // as a String using `http-headers`...
               // <https://github.com/nodejs/node/issues/28302>
-              { responseHeaders: res._header },
+              //
+              // note that HTTP2 responses do not have a String value
+              // for `res._header`, and instad is a Boolean value
+              // <https://github.com/nodejs/node/issues/30894>
+              // <https://github.com/cabinjs/cabin/issues/133>
+              {
+                responseHeaders:
+                  typeof res._header === 'string'
+                    ? res._header
+                    : typeof res.getHeaders === 'function'
+                    ? res.getHeaders()
+                    : null
+              },
               this.config.parseRequest
             )
           )