fix: error with pretty-print and jest #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jest detected hanging functions and I believe it's the translateTime pretty print option was not correct
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 80.00% 72.00% -8.00%
==========================================
Files 2 2
Lines 25 25
Branches 6 6
==========================================
- Hits 20 18 -2
- Misses 5 7 +2 ☔ View full report in Codecov by Sentry. |
snelg
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest detected hanging functions and I believe it's pino-pretty and jest don't work well together.
https://github.com/pinojs/pino-pretty?tab=readme-ov-file#usage-with-jest
I've tried adding the
syncproperty and that doesn't seem to help. So instead we can just default to not include pretty print if we're running tests. I suspect that the real issue is that jest with pretty print seem to introduce a race condition that doesn't always finish before jest finishes.