chore(deps): bump node version #1193
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettjay
force-pushed
the
refactor-and-bump-node
branch
from
408eeb1 to
9f1bcc4
Compare
GaryGSC
reviewed
May 1, 2024
There was a problem hiding this comment.
Thanks for the Node.js version update.
I'm also supportive of the switch to Fastify as our general recommendation.
We likely need further discussion about switching to the native test runner.
I added some thoughts about node --test usage. I like the direction, but it has its quirks and differences. It's a little annoying that coverage is still behind a flag. One other feature loss is that we no longer generate the pretty HTML coverage report that we used to get from Jest's LCOV reporter. I'm personally okay with that if we retain the Codecov bits. Here's what the HTML report looked like:
yoshutch
approved these changes
May 3, 2024
Co-authored-by: Gary Crye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started with bumping the node version then realized it might cut down on dependencies to move it to fastify. It was fast enough that I figured it was worth the effort. I won't be offended if we want to go another direction.