fix: check variadic function's cap before calling #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic9ac689e33484828b27adeca2d342e87c4230362
What type of PR is this?
fix
What this PR does / why we need it (en: English/zh: Chinese):
en: There are a few cases that
lastArgs.cap == 0butlastArg.len == MAX_INTwhen calling variadic functions (arm64). Currently we have no idea how it happens. In that case we assume thatlastArgs.lenshould less thanlastArg.capzh: 在一些极少情况下mock可变长参数的函数，调用时最后的变长参数slice的len会变得很大，但是cap为0。目前还不清楚为什么slice的len被踩坏了，这里先做一个校验，如果len>cap的话按照cap长度调用mock函数
Which issue(s) this PR fixes: