Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily remove moonbit from CI language matrix #1068

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pchickey
Copy link
Contributor

The moonbit CI job seems to be broken (https://github.com/bytecodealliance/wit-bindgen/actions/runs/11407779008/job/31744559397) due to some change to the compiler. This PR disables the CI jobs temporarily. Maybe when we re-enable it, we should pin a compiler version?

@pchickey pchickey requested a review from fitzgen October 18, 2024 17:32
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, keep running it in CI but allow the job to fail and for CI to still pass?

@pchickey
Copy link
Contributor Author

Agreed thats preferable, but I couldn't figure out the right incantation to do that on a matrix for just one column, some googling indicates its not supported actions/runner#2347

@pchickey pchickey added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit a780ad2 Oct 18, 2024
25 checks passed
@pchickey pchickey deleted the pch/ci_disable_moonbit branch October 18, 2024 19:31
@alexcrichton
Copy link
Member

cc @peter-jerry-ye to make sure you see this

@peter-jerry-ye
Copy link
Contributor

@alexcrichton Thank you for letting me know. The MoonBit is still an evolving language, and the standard library is still evolving, so I expect there'll be failures from time to time.

How about I create a separate CI file that executes only on pull request (when there are changes for wit-bindgen-moonbit only) and on a weekly basis?

@alexcrichton
Copy link
Member

Ah ok makes sense. Personally I find intended-to-fail CI pretty hard to wrangle so unfortunately I'm not sure of a good way to manage that. Failures on PRs look scary to contributors "not in-the-know" so I'd be hesitant to do that and a cron-based schedule often sends failure emails to the wrong person (e.g. the commit author rather than those interested). For now it may be best to leave it disabled until MoonBit has stabilized some more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants