Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): use node module resolution to resolve codegen cli path #73

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Owner

@byCedric byCedric commented Nov 22, 2022

Linked issue

See issue on the facebook/react-native#35429 repository.

Relavant xcode logging for failed build
FBReactNativeSpec.build/Script-46EB2E000116C0.sh
Node found at: /Users/expo/.nvm/versions/node/v16.13.2/bin/node
error: Could not determine react-native-codegen location in /Users/expo/workingdir/build/apps/mobile/ios/Pods/../../node_modules/react-native/React/FBReactNativeSpec/../../packages/react-native-codegen or /Users/expo/workingdir/build/apps/mobile/ios/Pods/../../node_modules/react-native/React/FBReactNativeSpec/../../../react-native-codegen. Try running 'yarn install' or 'npm install' in your project root.

warning: Run script build phase '[CP-User] Generate app.config for prebuilt Constants.manifest' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXConstants' from project 'Pods')
warning: Run script build phase '[CP-User] Generate app.manifest for expo-updates' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXUpdates' from project 'Pods')
warning: Run script build phase 'Start Packager' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'expomonorepo' from project 'expomonorepo')
warning: Run script build phase 'Bundle React Native code and images' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'expomonorepo' from project 'expomonorepo')

I'm going to merge the patch outside of this PR. Do not merge this, it's being used as example for the issue on facebook/react-native#35429.

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
expo-monorepo-example ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 2:13PM (UTC)

@github-actions
Copy link

This pull request was automatically deployed using Expo GitHub Actions!

  • Project: @bycedric/expo-monorepo
  • Channel: pr-73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant