Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/expo router #101

Closed
wants to merge 4 commits into from
Closed

Feat/expo router #101

wants to merge 4 commits into from

Conversation

tyrauber
Copy link

Linked issue

Closes #97.

Additional context

Since expo-router hit v2 and is included in Expo Go, I think it makes sense to include it in this repo.

This PR is a minimal implementation adding the dependencies, and configuring the plugin.

- add expo-router and dependencies
- configure expo-router plugin
- modify apps/mobile/index.js
- move App.tsx to apps/mobile/app/index.tsx
- update typescript to v5
- add dist to .gitignore
- update README.md in regards to dev-client
- remove as devDependencies (as they are already peer dependencies)
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
expo-monorepo-example ❌ Failed (Inspect) Aug 31, 2023 9:58pm

@byCedric
Copy link
Owner

byCedric commented Sep 1, 2023

Thanks for adding this! Be aware that I also want to fix some pnpm issues, before adding Expo Router. This includes removing the node-linker=hoisted workaround.

Work is underway for that!

(Also, ignore the Vercel deployment, it's a bit annoying that Vercel dropped this version before it's end of life)

@tyrauber
Copy link
Author

Closing in favor of #105

@tyrauber tyrauber closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble getting "expo-router" installed + starting
2 participants