-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to help keep tox and github CI configurations approximately in sync #86
Conversation
Pull Request Test Coverage Report for Build 4813998588
💛 - Coveralls |
f988472
to
29d51b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, now we have tests for our tests. This is getting very meta indeed 😆 I think this does address some of my concerns with maintainability, although I question whether or not there is a better way to do this. I'm not aware of what that better approach would look like though, so at least for the time being, this will do.
I think the issue is that there are 2 different ways to test the code, one using tox, the other using github actions. I think one of those should go and then we indirectly loose the duplication. My proposal would be the following:
Basically this boils down to removing tox. Alternatively, we could use https://github.com/ymyzk/tox-gh-actions to run tox using github actions. |
Internet points will be awarded for tests that verify that these tests work. Config file parsing probably a good candidate. :D |
Merging this one. Have raised an issue so that we can continue this discussion without comments disappearing as work is done: #87 |
29d51b4
to
181fa69
Compare
No description provided.