Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to help keep tox and github CI configurations approximately in sync #86

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

bwhmather
Copy link
Owner

No description provided.

@bwhmather bwhmather requested a review from jgberry April 26, 2023 22:31
@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Pull Request Test Coverage Report for Build 4813998588

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.225%

Totals Coverage Status
Change from base Build 4813893877: 0.0%
Covered Lines: 1273
Relevant Lines: 1296

💛 - Coveralls

Copy link
Collaborator

@jgberry jgberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, now we have tests for our tests. This is getting very meta indeed 😆 I think this does address some of my concerns with maintainability, although I question whether or not there is a better way to do this. I'm not aware of what that better approach would look like though, so at least for the time being, this will do.

@cgahr
Copy link
Collaborator

cgahr commented Apr 27, 2023

I think the issue is that there are 2 different ways to test the code, one using tox, the other using github actions. I think one of those should go and then we indirectly loose the duplication.

My proposal would be the following:

  • all linters (black, isort, pylint, pyflakes, maybe mypy) go into pre-commit.
  • we add a new github ci that runs pre-commit
  • we add proper pytest configuration to test the code locally with the installed python version
  • we run a matrix test for different OS and different python versions using github ci (as it is right now)

Basically this boils down to removing tox.

Alternatively, we could use https://github.com/ymyzk/tox-gh-actions to run tox using github actions.

@bwhmather
Copy link
Owner Author

Internet points will be awarded for tests that verify that these tests work. Config file parsing probably a good candidate. :D

@bwhmather
Copy link
Owner Author

Merging this one. Have raised an issue so that we can continue this discussion without comments disappearing as work is done: #87

@bwhmather bwhmather enabled auto-merge April 28, 2023 19:23
@bwhmather bwhmather disabled auto-merge April 28, 2023 20:33
@bwhmather bwhmather merged commit dbf23a8 into master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants