Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on windows as well as linux #64

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Run tests on windows as well as linux #64

merged 3 commits into from
Mar 28, 2022

Conversation

bwhmather
Copy link
Owner

Will do a separate one for OSX once this is passing.

@coveralls
Copy link

coveralls commented Mar 27, 2022

Pull Request Test Coverage Report for Build 2053638154

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 98.144%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ssort/_main.py 4 5 80.0%
src/ssort/_utils.py 4 5 80.0%
Totals Coverage Status
Change from base Build 2048889787: -0.07%
Covered Lines: 1269
Relevant Lines: 1293

💛 - Coveralls

@bwhmather bwhmather force-pushed the bwhm/windows-ci branch 5 times, most recently from 52e121a to 737c8ed Compare March 27, 2022 14:53
@bwhmather bwhmather marked this pull request as ready for review March 28, 2022 16:57
@bwhmather bwhmather requested a review from jgberry March 28, 2022 21:04
Copy link
Collaborator

@jgberry jgberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous concern if you did see it (I have since deleted it) as I realized it was not substantial.

This looks good.

@bwhmather bwhmather merged commit f179281 into master Mar 28, 2022
@bwhmather
Copy link
Owner Author

Have raised #66 to fix that todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants