Add a Painter variant of the placeholder APIs #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjudd
force-pushed
the
add_painter_placeholder
branch
from
500377b to
da1da08
Compare
sjudd
force-pushed
the
add_painter_placeholder
branch
from
da1da08 to
29f92ce
Compare
| @@ -65,7 +65,7 @@ import kotlin.math.roundToInt | |||
|
|
|||
| @ExperimentalGlideComposeApi | |||
| internal interface RequestListener { | |||
| fun onStateChanged(model: Any?, drawable: Drawable?, requestState: RequestState) | |||
| fun onStateChanged(model: Any?, painter: Painter?, requestState: RequestState) | |||
There was a problem hiding this comment.
fun onStateChanged(model: Any?, painter: Painter?, requestState: RequestState)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5224
We could go further and remove the drawable / resource id variants entirely, but it won't lead to a huge simplification internally because we still have to deal with those types from RequestBuilder.