Update to Gradle 5.6.4 #4484
Merged
Update to Gradle 5.6.4 #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanelbulle
requested changes
Jan 29, 2021
There was a problem hiding this comment.
Thanks for the change!
The checksum for the gradle-wrapper.jar does not match any known checksums of gradle releases. I think you might have built the wrapper without using the upgraded gradle version. See https://docs.gradle.org/current/userguide/gradle_wrapper.html#troubleshooting_a_checksum_mismatch for more info on how to correct this.
|
Are you sure? The Gradle Wrapper Validation action reports: |
|
You're right, I didn't see that! I was comparing manually with the published SHAs. Sorry about that & thanks for the change! |
benju69
approved these changes
Feb 12, 2021
kanelbulle
approved these changes
Feb 12, 2021
|
Apologies for the delay! Had to get this approved internally. |
|
No worries, thanks the effort and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Gradle Wrapper to version 5.6.4
Motivation and Context
Updating Gradle ensures that the latest warnings and depreciation messages are included. It also improves build speed.
Part of #4482.