-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nullability annotations to library module (1/n) #2681
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
@sjudd I couldn't find docs on updating the generated API tests. Could you help me fix those? Thanks! 😄 |
I need to write a script for them. Right now the best way I've found to do it is to run the tests in Android Studio, then click on the failure comparison. That will open a pretty useful window that shows the complete files and highlights the diff. If the diff looks reasonable you can copy/paste the new version into the old file. It's a pain :/. There's probably a better way of doing this... |
Oh I should also note that the files that we check against are stored in resources, here: https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources. Either the tests will have an identically named package under resources with their test classes (if their output differs from the default) or they default to the files in either https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest or https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources/EmptyLibraryGlideModuleTest. The helper class defines methods that are used to determine the actual path: glide/annotation/compiler/test/src/test/java/com/bumptech/glide/annotation/compiler/test/Util.java Line 15 in dc12b60
|
Signed-off-by: Alex Saveau <[email protected]>
Awesome thanks, sorry for the delay! |
No problemo, I haven't had time to work on the next batch anyway. |
Man this is painful! 😄 Here's what I got done before I ran out of podcasts.