Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotations to library module (1/n) #2681

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Add nullability annotations to library module (1/n) #2681

merged 3 commits into from
Dec 12, 2017

Conversation

SUPERCILEX
Copy link
Contributor

Man this is painful! 😄 Here's what I got done before I ran out of podcasts.

Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX SUPERCILEX changed the title Add nullability annotations Add nullability annotations to library module (1/n) Dec 5, 2017
@SUPERCILEX
Copy link
Contributor Author

@sjudd I couldn't find docs on updating the generated API tests. Could you help me fix those? Thanks! 😄

@sjudd
Copy link
Collaborator

sjudd commented Dec 6, 2017

I need to write a script for them. Right now the best way I've found to do it is to run the tests in Android Studio, then click on the failure comparison. That will open a pretty useful window that shows the complete files and highlights the diff. If the diff looks reasonable you can copy/paste the new version into the old file.

It's a pain :/. There's probably a better way of doing this...

@sjudd
Copy link
Collaborator

sjudd commented Dec 6, 2017

Oh I should also note that the files that we check against are stored in resources, here: https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources.

Either the tests will have an identically named package under resources with their test classes (if their output differs from the default) or they default to the files in either https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest or https://github.com/bumptech/glide/tree/dc12b60c8f0a21eb9b3ab2164471c93d2e20ae25/annotation/compiler/test/src/test/resources/EmptyLibraryGlideModuleTest.

The helper class defines methods that are used to determine the actual path:

Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Contributor Author

@sjudd Ok! After trying to figure it out off and on, I think I finally got it. See #2703 😄

@sjudd
Copy link
Collaborator

sjudd commented Dec 12, 2017

Awesome thanks, sorry for the delay!

@sjudd sjudd merged commit 0cffd1d into bumptech:master Dec 12, 2017
@SUPERCILEX SUPERCILEX deleted the kotlin-library-1 branch December 12, 2017 02:00
@SUPERCILEX
Copy link
Contributor Author

No problemo, I haven't had time to work on the next batch anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants