Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2650 #2676

Closed
wants to merge 1 commit into from
Closed

Closes #2650 #2676

wants to merge 1 commit into from

Conversation

Errryx
Copy link

@Errryx Errryx commented Dec 4, 2017

enhancement
Set default value for MemorySizeCalculator#isLowMemoryDevice to true
Closes #2650

Description

Motivation and Context

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@Errryx
Copy link
Author

Errryx commented Dec 4, 2017

I signed it!

@sjudd
Copy link
Collaborator

sjudd commented Dec 4, 2017

There's a failing test in the build failure:

:annotation:compiler:test:build
com.bumptech.glide.load.engine.cache.MemorySizeCalculatorTest > testCanSetCustomMemoryCacheSize FAILED
java.lang.AssertionError at MemorySizeCalculatorTest.java:60

@stale
Copy link

stale bot commented Dec 11, 2017

This issue has been automatically marked as stale because it has not had activity in the last seven days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the stale label Dec 11, 2017
@stale stale bot closed this Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value of isLowMemoryDevice
3 participants