-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlideModule annotation not provided in compile dependency for 4.6.0 #2863
Labels
Comments
yeah,,does your fixed? |
Ugh yeah sorry about that, I'll upload 4.6.1 with a fix when I verify it. It looks like the maven plugin only includes dependencies based on the release configuration, so when we removed it dependencies are no longer automatically added. |
Closed
sjudd
added a commit
to sjudd/glide
that referenced
this issue
Mar 6, 2018
------------- Include the debug aar in release artifacts for Android projects. We removed the release variant a while ago to speed up the build, which has the side affect of removing the release aar from artifacts. Since we expect the debug and release variants to be identical (hence why we disabled the release variant), it should be safe to just use the debug aar instead. We will have to specify it explicitly since android’s rules unsurprisingly only add the release variant by default. ------------- Bump version to 4.6.0 ------------- Update readme to 4.6.0 Also removes the old v4 dependency from maven deps, I don’t think it’s necessary. ------------- Change update_javadocs to use debugJavadocJar instead of release. We’ve disabled the release variant. ------------- Bump version to 4.7.0-SNAPSHOT ------------- Add POM dependencies explicitly. Fixes bumptech#2863. ------------- Bump version to 4.6.1 ------------- Update readme to 4.6.1 ------------- Fix param mistake (bumptech#2873) ------------- Update SimpleTarget javadoc to match v4 API. ------------- Add javadoc for RequestOptions.apply/RequestBuilder.apply. Related to bumptech#2858. ------------- Add support for Uri data uris. Previously we only supported data uris if they were provided as Strings. Fixes bumptech#556. ------------- Make GlideBuilder.build package private. It shouldn’t have been made visible and can’t safely be used directly outside of the library. Fixes bumptech#2885 ------------- Handle notifications in MultiFetcher after cancellation. We can’t guarantee that every fetcher implementation will strictly avoid notifying after they’ve been cancelled. This also improves the behavior in VolleyStreamFetcher so that it attempts to avoid notifying after cancel, although it still doesn’t make any strict guarantee. Fixes bumptech#2879 ------------- Re-enable -Werror for java compilation. Related to bumptech#2886. ------------- Fix a deprecation warning in DataUriTest. ------------- gradle 4.5.1 ------------- deprecate fragments ------------- add @deprecated to javadoc and suppress deprecations in code ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=99229725401d5777e059da7b6331134bf73fbcdf ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185535564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's simply not there, but it used to be in 4.5.0. In fact, all four transitive dependencies found in the pom for 4.5.0 are missing in 4.6.0.
The text was updated successfully, but these errors were encountered: