Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interlaced or downsampled GIFs with transparent pixels decode as static images #2698

Closed
sjudd opened this issue Dec 8, 2017 · 1 comment
Closed

Interlaced or downsampled GIFs with transparent pixels decode as static images #2698

sjudd opened this issue Dec 8, 2017 · 1 comment
Labels
bug
Milestone
4.5

Comments

@sjudd
Copy link
Collaborator

sjudd commented Dec 8, 2017

There's an NPE in the GIF decoder for these images that's causing Glide to fall back to decoding the static image.
@sjudd sjudd added this to the 4.4.1 milestone Dec 8, 2017
@sjudd sjudd added the bug label Dec 8, 2017
@sjudd
Copy link
Collaborator Author

sjudd commented Dec 8, 2017

Internal bug is b/70354071

sjudd added a commit to sjudd/glide that referenced this issue Dec 8, 2017
@sjudd
Fix static decoding of interlaced or downsampled transparent GIFs.
3e1f8a2 
The GifDecoder was NPEing, forcing Glide to fall back to BitmapFactory,
which can only decode static images. 

Fixes bumptech#2698
@sjudd sjudd closed this as completed in b64f23d Dec 9, 2017
@sjudd sjudd modified the milestones: 4.4.1, 4.5 Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
1 participant
@sjudd