A few updates to the getting started docs #1330
Conversation
Signed-off-by: Natalie Arellano <[email protected]>
| ```bash | ||
| kubectl cluster-info # ensure you have access to a cluster | ||
| ./hack/apply.sh <IMAGE/NAME> # <IMAGE/NAME> is a writable and publicly accessible location | ||
| docker login <registry namespace> # must be writable and publicly accessible; e.g., your Docker Hub username or gcr.io/<some-project> |
There was a problem hiding this comment.
An image "name" such as some-docker-username/random-image causes the tests to fail
|
|
||
| Several unit tests depend upon libgit2 v1.3.0. |
There was a problem hiding this comment.
This seems to no longer be true
|
|
||
| ```bash | ||
| IMAGE_REGISTRY=gcr.io/<some-project> go test ./test/... | ||
| IMAGE_REGISTRY=gcr.io/<some-project> \ |
There was a problem hiding this comment.
Side note, while ./hack/apply.sh works with index.docker.io I couldn't get the end-to-end tests to pass this way (they failed with "unauthorized" error). I recall there are some oddities WRT ggcr/docker and Docker Hub specifically, but I didn't dig too much here.
There was a problem hiding this comment.
ya there are some weirdisms but I forget the exact config needed for running the e2e tests against dockerhub
| @@ -65,64 +76,29 @@ EOF | |||
| ### Running Unit Tests | |||
|
|
|||
| ```bash | |||
| go test ./pkg/... | |||
| make unit | |||
There was a problem hiding this comment.
Using make allows us to inherit the timeout which I hit on one of the suites
Based on getting
e2eworking for the first time