PHP 8.4 compatibility #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
Open
|
@imjoehaines @tomlongridge could you please review and merge this and cut a new release to support PHP 8.4? |
|
Hi @danepowell Thanks for taking the time to raise this PR. We are currently investigating and discussing support for PHP 8.4 internally, which includes evaluating this PR. We'll make sure to post any updates here as they become available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix #670
Design
Changeset
Remove E_STRICT and add explicit nullable types. This requires changing the minimum PHP version. Supposedly E_STRICT hasn't been used since PHP 8 so it should be safe to remove: https://php.watch/versions/8.4/E_STRICT-deprecated
Testing
I can only confirm this fixes the errors, I haven't tested it otherwise.