Allow overriding context set by servlet callback #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.gradle
Outdated
| @@ -32,6 +32,8 @@ dependencies { | |||
|
|
|||
| testCompile 'junit:junit:4.12' | |||
| testCompile 'org.slf4j:slf4j-jdk14:1.7.25' | |||
| testCompile 'javax.servlet:javax.servlet-api:3.1.0' | |||
| testCompile 'org.mockito:mockito-core:2.+' | |||
There was a problem hiding this comment.
It would be good to lock this to a specific version.
fractalwrench
approved these changes
Oct 10, 2017
Add mockito for testing servlet logic
kattrali
force-pushed
the
kattrali/fix-overriding-servlet-context
branch
from
f00a3cb to
e09f332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a report generated like so and captured from a servlet context:
The context in the final report should retain "custom context" and not be overridden by callbacks.