add aopproxyutils dependancy and add handling in scheduledTaskConfig class #218
+76
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
reviewed
Jul 16, 2024
bugsnag-spring/src/jakartaTest/java/com/bugsnag/ScheduledTaskConfigurationTest.java
Show resolved
Hide resolved
Merged
clr182
added a commit
that referenced
this pull request
Aug 29, 2024
* (docs): update docs references from `master` to `main` * (docs): switch build status badge to buildkite * Update selector to accept only the major version * Update Changelog * update linting * Added severity check (#214) * added severity check * fixed linting * fixed linting v2 * added changelog entry * Reverting changes * update notify override with null check * Update changelog * Update Bugsnag.java call notify override method on null severity * add aopproxyutils dependancy and add handling in scheduledTaskConfig class (#218) * add aopproxyutils dependancy and add handling in scheduledTaskConfig class * fixed comment typo * fixed import of aoputils * added proxy testing * fixed linting * Updated tests * updated tests * update changelog * moving createProxy method to util class * update variable name * reverting * Update Serializer object to be an interface (#219) * Adding non serializable metadata handling * removed an unused import * update feature * update changelog * Add serializeObject public method * Fixed linting * fixed tests * Implemented Serializer interface * update scenarios * update changelog * Changes based on feedback * update tests * updates based on reviews * Update bugsnag/src/main/java/com/bugsnag/Configuration.java Co-authored-by: Tom Longridge <[email protected]> * update config --------- Co-authored-by: Tom Longridge <[email protected]> * v3.7.2 --------- Co-authored-by: Yousif Ahmed <[email protected]> Co-authored-by: Yousif <[email protected]> Co-authored-by: Tom Longridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The following warning appears when starting the SpringBootWeb application.
“com.bugsnag.ScheduledTaskConfiguration : Bugsnag scheduled task exception handler could not be configured”.
This happens when adding the
@EnableSchedulingannotationDesign
Checked the ScheduledTaskRegister to determine whether it is a proxy of the original object, then get the target class of the original object if it is and cast it as the taskSchedular before configuring the existing taskScheduler.
Changeset
Added new AoP springboot dependencies for accessing the original ScheduledTaskSchedular object.
Added checking to the ConfigureTasks method in ScheduledTaskConfiguration.java to determine whether the passed object is a proxy or not.
Handle cases where this is or isn't a proxy within the configureTasks method
Testing
Added two tests to determine if the taskScheduler object is a proxy.