Swallow Throwables thrown when configuring bugsnag appender #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uded loggers not all clients use Logback, so the dependency may throw an error relating to the class def not being found. We should swallow this and continue initialising bugsnag as normal.
kattrali
reviewed
Apr 12, 2019
bugsnag-spring/src/main/java/com/bugsnag/BugsnagSpringConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Not all users use Logback in their project, so
BugsnagSpringConfigurationcallingBugsnagAppendermethods can throw aNoClassDefFoundError, as observed in #132. If the dependency is not on the classpath, we should ignore this error and continue initialising bugsnag as normal.Tests
Ran the example app with logback excluded, and confirmed that this change allowed the application to startup.