Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add svg image with href support #198

Merged
merged 3 commits into from
Oct 9, 2021

Conversation

isergey87
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@biiibooo
Copy link
Contributor

biiibooo bot commented Oct 8, 2021

👋 @isergey87

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #198 (5b13ad5) into master (297b17f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   79.93%   79.93%           
=======================================
  Files          10       10           
  Lines         578      578           
  Branches      101      101           
=======================================
  Hits          462      462           
  Misses         56       56           
  Partials       60       60           
Impacted Files Coverage Δ
src/embedImages.ts 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4f1b4...5b13ad5. Read the comment docs.

@bubkoo bubkoo merged commit cb6f916 into bubkoo:master Oct 9, 2021
@biiibooo
Copy link
Contributor

biiibooo bot commented Oct 9, 2021

👋 @isergey87 Congrats on merging your first pull request! 🎉🎉🎉

github-actions bot pushed a commit that referenced this pull request Oct 9, 2021
# [1.9.0](v1.8.5...v1.9.0) (2021-10-09)

### Bug Fixes

* Large Dom sizes failing to be drawn correctly into canvas when exporting to PNG ([#197](#197)) ([1ee2e7f](1ee2e7f))

### Features

* ✨ add svg image with href support ([#198](#198)) ([cb6f916](cb6f916))
@biiibooo
Copy link
Contributor

biiibooo bot commented Oct 9, 2021

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

@biiibooo biiibooo bot added the released label Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants