Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error return value for SignCompact #2211

Merged
merged 1 commit into from
Jul 10, 2024
Merged

remove error return value for SignCompact #2211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion btcec/ecdsa/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func BenchmarkSignCompact(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
_, _ = SignCompact(privKey, msgHash, true)
_ = SignCompact(privKey, msgHash, true)
}
}

Expand Down
4 changes: 2 additions & 2 deletions btcec/ecdsa/signature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,9 @@ func ParseDERSignature(sigStr []byte) (*Signature, error) {
// <(byte of 27+public key solution)+4 if compressed >< padded bytes for signature R><padded bytes for signature S>
// where the R and S parameters are padde up to the bitlengh of the curve.
func SignCompact(key *btcec.PrivateKey, hash []byte,
isCompressedKey bool) ([]byte, error) {
isCompressedKey bool) []byte {

return secp_ecdsa.SignCompact(key, hash, isCompressedKey), nil
return secp_ecdsa.SignCompact(key, hash, isCompressedKey)
}

// RecoverCompact verifies the compact signature "signature" of "hash" for the
Expand Down
6 changes: 1 addition & 5 deletions btcec/ecdsa/signature_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,11 +479,7 @@ func testSignCompact(t *testing.T, tag string, curve *btcec.KoblitzCurve,
priv, _ := btcec.NewPrivateKey()

hashed := []byte("testing")
sig, err := SignCompact(priv, hashed, isCompressed)
if err != nil {
t.Errorf("%s: error signing: %s", tag, err)
return
}
sig := SignCompact(priv, hashed, isCompressed)

pk, wasCompressed, err := RecoverCompact(sig, hashed)
if err != nil {
Expand Down
Loading