Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent app creation without wallet creation #6255

Merged
merged 3 commits into from
Sep 27, 2024
Merged

prevent app creation without wallet creation #6255

merged 3 commits into from
Sep 27, 2024

Conversation

TChukwuleta
Copy link
Contributor

  • Added check to ensure a wallet is set up before creating an app
  • App type is now included in the wallet setup message to provide more context to the user

image

dstrukt
dstrukt approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - LGTM functionally

Even worked with an existing CF that I was able without payment method before testing this PR.

@NicolasDorier NicolasDorier merged commit 83fa8cb into btcpayserver:master Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrukt dstrukt dstrukt approved these changes

@dennisreimann dennisreimann Awaiting requested review from dennisreimann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TChukwuleta @dstrukt @NicolasDorier