Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Role Permissions more human legible #6191

Merged

Conversation

dennisreimann
Copy link
Member

Had to rename CanModifyStoreWebhooks to CanModifyWebhooks for this, but the value stayed the same, so I don't think it's a big deal.

Closes #6183.

grafik

Had to rename `CanModifyStoreWebhooks` to `CanModifyWebhooks` for this, but the value stayed the same, so I don't think it's a big deal.

Closes btcpayserver#6183.
@dennisreimann
Copy link
Member Author

Will add another PR to clean up the deprecated custodian account permissions.

@dstrukt dstrukt self-requested a review September 4, 2024 15:37
@dstrukt
Copy link
Member

dstrukt commented Sep 4, 2024

Awesome - this looks like what they wanted, and it looks like it takes up roughly about the same amount of space.

I will admit, I know the distinction between Store/Server is necessary so that we must keep it, but
Can Modify Store Settings / Can Modify {Store} {X}

reads a bit easier than
Store: Can Modify {X}

no?

And carries over to the Server case too
Can Modify {Server} {X} just as easily?

Will review asap as well!

@dennisreimann
Copy link
Member Author

no?

yes, but we cannot infer that from what we have. We'd have to refactor the code to achieve something better.

@dennisreimann
Copy link
Member Author

Follow-up PR is #6193.

@dstrukt
Copy link
Member

dstrukt commented Sep 6, 2024

no?

yes, but we cannot infer that from what we have. We'd have to refactor the code to achieve something better.

I see, sounds good, this more than satisfies the requirement for the time being, and a refactor for that minor copy detail isn't a good use of time atm.

Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

Thanks for taking care of this so quickly!

@NicolasDorier NicolasDorier merged commit 3342122 into btcpayserver:master Sep 12, 2024
4 checks passed
@dennisreimann dennisreimann deleted the legible-role-permissions branch September 12, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Role Permissions more human legible
3 participants