Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greenfield: Add missing invoice metadata to Lightning Address #6084

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Greenfield: Add missing invoice metadata to Lightning Address #6084

merged 2 commits into from
Jul 4, 2024

Conversation

dennisreimann
Copy link
Member

Closes #6067.

Can also be backported to v1.13.x.

@dennisreimann dennisreimann added the API Questions and issues related to API label Jul 3, 2024
@dennisreimann dennisreimann requested a review from Kukks July 3, 2024 15:52
@pavlenex pavlenex added this to the 1.13.4 milestone Jul 3, 2024
louieo
louieo reviewed Jul 3, 2024
View reviewed changes
Copy link

@louieo louieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Tested adding and updating lightning address with and without JSON metadata.

Also, I'm looking for feedback - is this way I am testing useful/appropriate? Open to any guidance to help me contribute in the best way!

image

@dennisreimann
Copy link
Member Author

dennisreimann commented Jul 3, 2024 •
edited
Loading

Yes, thanks for testing it in Postman! I also added an automated unit test, but manual testing in Postman is often my first step too when working on the API.

@louieo
Copy link

louieo commented Jul 3, 2024

Yes, thanks for testing it in Postman! I also added an automated unit test, but manual testing in Postman is often my first step too when working on the API.

Ok great! Thanks.

@NicolasDorier NicolasDorier merged commit f7569b7 into btcpayserver:master Jul 4, 2024
4 checks passed
dennisreimann added a commit that referenced this pull request Jul 4, 2024
@dennisreimann
Greenfield: Add missing invoice metadata to Lightning Address (#6084)
8aae388 
* Greenfield: Add missing invoice metadata to Lightning Address

Closes #6067.

* Update BTCPayServer/wwwroot/swagger/v1/swagger.template.stores-lightning-addresses.json
@dennisreimann dennisreimann deleted the gf-lnaddress-metadata branch July 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louieo louieo louieo left review comments

@NicolasDorier NicolasDorier NicolasDorier left review comments

@Kukks Kukks Awaiting requested review from Kukks

Assignees
No one assigned
Labels
API Questions and issues related to API
Projects
BTCPay Server Roadmap 🛣️
Status: Done ✅
Milestone
1.13.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dennisreimann @louieo @NicolasDorier @pavlenex