Cleanup data from the InvoiceEvents table #5904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR save 43% of space in the biggest table in BTCPay Server's schema without deleting any useful data.
An unused 10-byte
UniqueId
column is included in every line of logs. This column was originally required to satisfy Entity Framework, but by switching to Dapper, we can eliminate it and save 20 bytes per log line (including index and table data).VACUUM FULL
ensures that the space of the removed column is reclaimed by the OS.ANALYZE
ensures that the new index get used.To
Incidentally, the code is more concise.