Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Can't save email settings on store level #6076

Closed
1 task done
ndeet opened this issue Jul 2, 2024 · 1 comment · Fixed by #6080
Closed
1 task done

[Bug]: Can't save email settings on store level #6076

ndeet opened this issue Jul 2, 2024 · 1 comment · Fixed by #6080
Assignees
@dennisreimann
Labels
Bug
Milestone
1.13.4

Comments

@ndeet
Copy link
Contributor

ndeet commented Jul 2, 2024

What is your BTCPay version?

v1.13.3

How did you deploy BTCPay Server?

docker

What happened?

When you do NOT have email setup on server settings BUT you want to setup email at store settings it will fail to save.

I suspect this has to do with the toggle that appears once you have set up the server email you can toggle so you can save also different settings on the store level. But maybe something else

How did you encounter this bug?

  • do not SETUP email in server settings
  • try to setup email in the store settings
  • fails to save, gives a 302 http response code

Relevant log output

No response

What browser do you use?

No response

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@pavlenex pavlenex added this to the 1.13.x milestone Jul 2, 2024
@pavlenex pavlenex added the Bug label Jul 2, 2024
@dennisreimann dennisreimann self-assigned this Jul 2, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Jul 2, 2024
@dennisreimann
Fix email settings on store level, when server has no email settings
120b90b 
Fixes btcpayserver#6076.
@dennisreimann
Copy link
Member

I suspect this has to do with the toggle that appears once you have set up the server email you can toggle so you can save also different settings on the store level.

💯🎯

@dennisreimann dennisreimann mentioned this issue Jul 2, 2024
Merged
@pavlenex pavlenex moved this from Backlog 🪵 to In Progress 🏗️ in BTCPay Server Roadmap 🛣️ Jul 3, 2024
@pavlenex pavlenex linked a pull request Jul 3, 2024 that will close this issue
Fix email settings on store level, when server has no email settings #6080
Merged
@pavlenex pavlenex modified the milestones: 1.13.x, 1.13.5 Jul 3, 2024
NicolasDorier pushed a commit that referenced this issue Jul 9, 2024
@dennisreimann
Fix email settings on store level, when server has no email settings (#…
3504175 
…6080)

* Fix email settings on store level, when server has no email settings

Fixes #6076.

* docker-compose: Add missing restart for merchant CLN container
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in BTCPay Server Roadmap 🛣️ Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisreimann dennisreimann

Labels
Bug
Projects
BTCPay Server Roadmap 🛣️
Status: Done ✅
Milestone
1.13.4
Development

Successfully merging a pull request may close this issue.

Fix email settings on store level, when server has no email settings dennisreimann/btcpayserver
3 participants
@dennisreimann @ndeet @pavlenex