Adding decodeWithByteRanges: string_views into translated-text #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to solve browsermt/bergamot-translator#25. Might be useful for marian-nmt#775 (?)
Changes test to accommodate the decoded string_views as well. The square-brackets indicate annotations using string_views, constructed by src/tests/sentencepiece_norm.cpp. The test previously for
encodeWithByteRanges
is modified to includedecodeWithByteRanges
as well. Once the expected is set to the output, this regression-tests can be modified as well.Input Text
Output
Requesting review.